Skip to content

Rust: Minor path resolution fix for ($)crate paths #19220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 4, 2025

Only matters to rust-lang/rust, where the prelude exists in both source code and in the crate graph, so we need to handle both.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Apr 4, 2025
@hvitved hvitved marked this pull request as ready for review April 7, 2025 07:33
@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 07:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@hvitved hvitved requested a review from paldepind April 7, 2025 07:34
@hvitved hvitved merged commit ca5cc8e into github:main Apr 7, 2025
16 checks passed
@hvitved hvitved deleted the rust/path-resolution-crate-fix branch April 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants